search

beam-telemetry / telemetry_metrics_prometheus_core

Core Prometheus Telemetry.Metrics Reporter package for telemetry_metrics_prometheus
Apache License 2.0
35 stars 30 forks source link

Skip debug logging for nil value #29

Closed bryannaegele closed 4 years ago

bryannaegele commented 4 years ago

This is very noisy for Ecto where there are a lot of nil values.

codecov-commenter commented 4 years ago

Codecov Report

Merging #29 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #29   +/-   ##
=======================================
  Coverage   98.28%   98.28%           
=======================================
  Files           9        9           
  Lines         233      233           
=======================================
  Hits          229      229           
  Misses          4        4
Flag Coverage Δ
#1_10_otp21 98.28% <ø> (ø)
#1_10_otp22 98.28% <ø> (ø)
#1_6_otp20 98.28% <ø> (ø)
#1_6_otp21 98.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/core/event_handler.ex 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fe38c26...3c2fa21. Read the comment docs.