akoutmos commented 4 years ago

The purpose of this PR is to update the handle_event function to handle the passing or metadata forward to user defined functions of arity 2 ( since this functionality is available as a result of https://github.com/beam-telemetry/telemetry_metrics/pull/82).

Will be adding tests later today, but wanted to get this out in PR for feedback first. Thanks in advance!

codecov-io commented 4 years ago

Codecov Report

Merging #32 (d9a45ca) into master (a987f6a) will increase coverage by 0.02%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #32      +/-   ##
==========================================
+ Coverage   98.28%   98.31%   +0.02%     
==========================================
  Files           9        9              
  Lines         233      237       +4     
==========================================
+ Hits          229      233       +4     
  Misses          4        4

Flag	Coverage Δ
1_10_otp21	`98.31% <100.00%> (+0.02%)`	:arrow_up:
1_10_otp22	`98.31% <100.00%> (+0.02%)`	:arrow_up:
1_6_otp20	`98.31% <100.00%> (+0.02%)`	:arrow_up:
1_6_otp21	`98.31% <100.00%> (+0.02%)`	:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
lib/core/distribution.ex	`100.00% <100.00%> (ø)`
lib/core/event_handler.ex	`100.00% <100.00%> (ø)`
lib/core/last_value.ex	`100.00% <100.00%> (ø)`
lib/core/sum.ex	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a987f6a...d9a45ca. Read the comment docs.

akoutmos commented 4 years ago

Giving this one a friendly bump :)

beam-telemetry / telemetry_metrics_prometheus_core

Adding support for 2 artiy measurements function #32

Codecov Report