beam-telemetry / telemetry_metrics_prometheus_core

Core Prometheus Telemetry.Metrics Reporter package for telemetry_metrics_prometheus
Apache License 2.0
35 stars 30 forks source link

Cleans up on normal termination #4

Closed bryannaegele closed 5 years ago

bryannaegele commented 5 years ago

During additional testing for bryannaegele/telemetry_metrics_prometheus#18 for the default configuration, clashes between tests arose due to a lack of cleaning up telemetry events.

codecov-io commented 5 years ago

Codecov Report

Merging #4 into master will increase coverage by 0.02%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #4      +/-   ##
==========================================
+ Coverage   99.07%   99.09%   +0.02%     
==========================================
  Files          11       11              
  Lines         216      221       +5     
==========================================
+ Hits          214      219       +5     
  Misses          2        2
Flag Coverage Δ
#1_6_otp20 99.09% <100%> (+0.02%) :arrow_up:
#1_6_otp21 99.09% <100%> (+0.02%) :arrow_up:
#1_9_otp20 ?
#1_9_otp22 99.09% <100%> (+0.02%) :arrow_up:
Impacted Files Coverage Δ
lib/core/registry.ex 98.18% <100%> (+0.18%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 51f3578...e0aafd8. Read the comment docs.