Work with newer Elixir versions

beam-telemetry / telemetry_metrics_prometheus_core

Core Prometheus Telemetry.Metrics Reporter package for telemetry_metrics_prometheus

Apache License 2.0

35 stars 30 forks source link

Work with newer Elixir versions #60

Closed IvanIvanoff closed 8 months ago

IvanIvanoff commented 8 months ago

Fixes for https://github.com/beam-telemetry/telemetry_metrics_prometheus_core/issues/59

Update ssl_verify_fun in order to work with newer Elixir versions
- Reference: https://github.com/deadtrickster/ssl_verify_fun.erl/pull/27
Fix usage of ~S sigil

bryannaegele commented 8 months ago

Ok. This was introduced with this PR and the test expectation is all sigiled. Can you update that test to a heredoc with the expected text in final form to verify the change works as expected and it's readable without sigils testing sigils?

IvanIvanoff commented 8 months ago

Someone reported the same this PR fixes (https://github.com/beam-telemetry/telemetry_metrics_prometheus_core/issues/59) in the Elixir Github issues and Josè reverted the change. This PR is no longer needed. Ref: https://github.com/elixir-lang/elixir/issues/13262