beam-telemetry / telemetry_metrics_statsd

Telemetry.Metrics reporter for StatsD-compatible metric servers
https://hexdocs.pm/telemetry_metrics_statsd
MIT License
75 stars 44 forks source link

Replace NimbleOptions `rename_to` with a custom function #69

Closed hoyon closed 2 years ago

hoyon commented 2 years ago

Fixes #68

This PR replaces the nimble_options :replace_to with a custom function which achieves the same thing as this option is now deprecated in nimble_options 0.4.

I've also upgraded nimble_options to 0.4.

We had an issue with running the tests locally as it seems the capture_logs in some tests aren't capturing long enough to capture the expected error logging. Adding Process.sleep fixes those tests but of course that isn't an ideal solution so I've left the tests as is for now.

arkgil commented 2 years ago

Thanks @hoyon, looks great! ⚡

ximura commented 2 years ago

Hi @arkgil Are you planning releasing this fix?

arkgil commented 2 years ago

Just pushed 0.6.2 to hex: https://hexdocs.pm/telemetry_metrics_statsd/0.6.2/TelemetryMetricsStatsd.html 🚀