Closed hperrey closed 9 years ago
Hey there, thanks a lot for the comments!
quick answer to the general comments:
Hanno, the EUTelescope reference is a weak point indeed. One of the options would be to have the AIDA Note on the EUTelescope published on Arxiv turned into a JINST paper with all relevant people on the author list
@TCThenna There had been an interface to GBL in 0.9.x, but it was not really generically usable. For this, quite a lot of additional work had been needed. So for the "original" EUDET telescope, GBL had not been a part of EUTelescope, and strictly speaking there is still no formally released version with full support of GBL. But in a way, this is a little pedantic -- as long as all contributors are mentioned in some form, I am fine with however you choose to handle this. For the EUTel paper I would strongly argue for a proper release of EUTel with GBL though!
By the way: I really appreciate going the Open Access route with the publication! That reminds me of two additional comments:
@rubinsky I knew I was forgetting a (or the?) key person!
Was the EUDAQ move to GPL ever finished? I just remember the mail and stone w answers but no code changes etc.
Richard and I will release EUDAQ 1.5 in a few weeks - maybe that would be time for a proper transition...
Am 12. Mai 2015 14:39:08 MESZ, schrieb Hanno Perrey notifications@github.com:
@TCThenna There had been an interface to GBL in 0.9.x, but it was not really generically usable. For this, quite a lot of additional work had been needed. So for the "original" EUDET telescope, GBL had not been a part of EUTelescope, and strictly speaking there is still no formally released version with full support of GBL. But in a way, this is a little pedantic -- as long as all contributors are mentioned in some form, I am fine with however you choose to handle this. For the EUTel paper I would strongly argue for a proper release of EUTel with GBL though!
By the way: I really appreciate going the Open Access route with the publication! That reminds me of two additional comments:
- one could mention EUDAQ (and hopefully soon EUTel?) being GPL-licensed
- you could mention the telescopes portal site https://beam-telescopes.desy.de as this collects all information regarding the telescopes
@rubinsky I knew I was forgetting a (or the?) key person!
Reply to this email directly or view it on GitHub: https://github.com/eudaq/StatusTelescope2015-Paper/issues/7#issuecomment-101260645
Hi @hperrey and @rubinsky the EUTelescope version referenced and used is 0.9.3 dating back to Jan. 17 2014. Thus, no formal GBL tracking processor is provided, but several groups (CMS Pixel e.g.) already use their own GBL implementation since years. This drove us to put this one single mentioning of GBL into Section5 - but that could of course be removed if desired.
EUTelescope 1.0 will be subject to a dedicated paper going all into the details of various alignment and tracking possibilities - then of course also including the very active authors of the software starting from Feb. 2014.
Cheers, Simon
@simonspa Thanks for the clarifications! I am absolutely fine with the decision to factorize the telescope (software) components like this and just wanted to avoid advertising features not (yet) included ;)
Also, EUDAQ is under GLPv3, at least the version in the master branch is: https://github.com/eudaq/eudaq/blob/master/LICENSE.md However, I have not modified e.g. file headers and such -- feel free to do so for any future release! We have had the ok from all authors to go forward with this change.
@simonspa Ah, and here is the corresponding pull request for the license change: https://github.com/eudaq/eudaq/pull/80
Nice, I even merged it myself... :) Okay I guess I was mislead by the file headers. We are thinking about a code beatification anyways and might add it alongside.
Thanks!
On 12.05.2015 16:30, Hanno Perrey wrote:
@simonspa https://github.com/simonspa Ah, and here is the corresponding pull request for the license change: eudaq/eudaq#80 https://github.com/eudaq/eudaq/pull/80
— Reply to this email directly or view it on GitHub https://github.com/eudaq/StatusTelescope2015-Paper/issues/7#issuecomment-101301286.
We are citing the TLU user manual because the Memo is terribly outdated and does not provide further information (it references TLU v0.1a)
Hej telescope team,
thank you for this detailed, thorough and well-written paper -- it was a pleasure to read! :)
So my comments really boil down to some nit-picking concerning wording; the only two general comments I have would be:
Now, into the nit-picking (please treat anything affecting wording/language as suggestion only!):