Closed fongkenrui closed 1 year ago
That sounds sensible to me at least, although I would definitely use temperature
rather than temp
in names. temp_data_path
reads too much like "path for temporary data" to me!
If you want to use exactly the same functional forms as the density_fit
forms, we might think about how to reuse the code, for example we could rename density_fit
to profile_fit
. Then you could skip the first step, and make_temperature_fit
and make_density_fit
can make use of the existing code.
This has been resolved as of the relativistic Scotty commit.
I was assigned to implement relativistic corrections for electron mass, which only affects cyclotron freq and plasma freq, and flows to the rest of the code via the DielectricTensor class. Current plan for implementation is as follows:
Would appreciate any suggestions on how this might be better implemented.