search

beam-tracing / Scotty

Beam tracing code for diagnostics
https://scotty.readthedocs.io/en/latest/
GNU General Public License v3.0
7 stars 4 forks source link

Possible bug in `ABCD_Lens`? #39

Open ZedThree opened 2 years ago

ZedThree commented 2 years ago

This only uses Psi_w_in[0, 0] -- should it be Psi_w_in[ii, ii], or is this correct?

https://github.com/valerian-chen/Scotty/blob/9e1b154a319038e08509060daace50eac5b78734/scotty/lensalot.py#L198-L199

valerian-chen commented 2 years ago

It should be the latter, but right now, I'm assuming a circular beam because Scotty cannot take elliptical beams as an initial condition (yet)

valerian-chen commented 2 years ago

Hm. Probably good to change it to ii, ii for now, after all, it'll still work