beam-tracing / Scotty

Beam tracing code for diagnostics
https://scotty.readthedocs.io/en/latest/
GNU General Public License v3.0
7 stars 4 forks source link

Launch beam refactoring #77

Closed ZedThree closed 1 year ago

ZedThree commented 1 year ago

(WIP until #74 is merged)

Pulls out the beam launch code into a separate functions and a new file, scotty.launch.

Fixes a bug where the toroidal launch angle was not taken into account for finding the launch entry position. This may affect simulations with large toroidal launch angles.

Enables launching from the inboard side (although more changes are required for this to work properly, namely the derivative stencils).

Still to do:

valerian-chen commented 1 year ago

Looks great. After you've completed this, I'll implement general non-circular beams at launch. That is, for arbitrary Psi_w_initial

ZedThree commented 1 year ago

@valerian-chen I've added some more docs and rearranged things a little bit, so this is ready for review now