search

beam-tracing / Scotty

Beam tracing code for diagnostics
https://scotty.readthedocs.io/en/latest/
GNU General Public License v3.0
7 stars 4 forks source link

Remove some unused modules #88

Closed ZedThree closed 1 year ago

ZedThree commented 1 year ago

I don't think these modules are used at all, so they can go

ZedThree commented 1 year ago

Ah, we could check that the first/second derivative is below some tolerance?

valerian-chen commented 1 year ago

Yes, I'm thinking some sort of spike detection, like find_peaks in scipy? It can be pretty easier, just checking over the LCFS versus rho=0.9 or something like that. Let me know what you think and I'll try to implement it? I need more practice with unit test