search

beamable / BeamableProduct

The beamable product suite including com.beamable, com.beamable.server, microservice base image, portal, the installer, and build scripts
Other
5 stars 0 forks source link

change microservice env var names to be consistent #3231

Open cdhanna opened 5 months ago

cdhanna commented 5 months ago

env vars like CID or PID or SECRET should have some level of consistency....

BEAM_CID
BEAM_PID
BEAM_SECRET

etc...

We should take 2.0 as an opportunity to rename all these config options in the Microservice base code. We need a beamo scala ticket to adjust the task definitions.

These are defined in the EnvironmentArgs type.

Actually, in the C#MS code, we should look for BEAM_CID, and fallback to CID, and then we don't need to address the beamo side until much much later after this fix has been shipped for years.

The generate-env CLI command needs to WRITE the new style naming conventions as well.

cdhanna commented 3 months ago

officially kicking this to "3.0" mind time.