search

beamable / BeamableProduct

The beamable product suite including com.beamable, com.beamable.server, microservice base image, portal, the installer, and build scripts
Other
3 stars 0 forks source link

CLI - should reuse docker image layers and skip upload when no changes #3478

Open dpatekar opened 3 weeks ago

dpatekar commented 3 weeks ago

beam services deploy seems to upload the service images on every run, even if there are no changes.

cdhanna commented 3 weeks ago

first thing to check, if we build the docker image, then rebuild the docker image, are the resulting image ids the same? If yes, then we shouldn't re-upload the service. This is a simple string image-id comparison.

Is there a way to get the resulting hash imageId of a tarball WITHOUT doing the docker build?

Investigate the layer hash changes between runs... Why are they?

we should verify that the CreateTarballForDirectory function's preprocess,

            if (file.Contains("/bin/") || file.Contains("/obj/"))
            {
                continue;
            }

in working as intended...

cdhanna commented 3 weeks ago

another thing we can do is check if the individual layers are uploaded. Talk to Ben!

Potentially, we ask Beamo what we upload, and it tells us all the stuff to do.