beamable / BeamableProduct

The beamable product suite including com.beamable, com.beamable.server, microservice base image, portal, the installer, and build scripts
Other
4 stars 0 forks source link

USAM - Our GHA tests on PRs fail if the version is 0.0.123 #3524

Open gabrielbeamable opened 1 week ago

gabrielbeamable commented 1 week ago

Basically, when running tests and builds on GHA for a PR, it runs the command beam download-all-nuget-packages passing the desired version. If that version is 0.0.123, it will just thrown an exception. This makes like we will always have to push a pushed version of nuget, if we have the tests running on updated versions of all packages.

Could we just change the behaviour of this when the version is 0.0.123 to instead of downloading the packages from nuget, just running the .set-packages.sh script, unpack the packages and copy it to the Packages/ folder in the Unity project to test?

cdhanna commented 1 week ago

Instead of this,

if (info.beamableNugetVersion == "0.0.123")
{
    throw new CliException("Cannot download nuget packages for developer 0.0.123 version.");
}

inside the if block, we should assume that a local nuget package source exists with 0.0.123, and we can unpackage the files from there.

The DownloadPackage function is

  1. downloading the package from nuget.org, but also
  2. writing a subset of the package to a local folder.

We'll still need to do part 2, but we can replace part 1 with reading the local package file zip. (when the version is 0.0.123)

The hard part will be answering the question, "where is the local zip file for 0.0.123?"