search

beamandrew / cui2vec

Other
51 stars 7 forks source link

Constructing pointwise mutual information directly from sparse matrix #1

Open kaushikacharya opened 4 years ago

kaushikacharya commented 4 years ago

In R/word2vec_fit.R # construct_pmi() do we really need to convert input sparse matrix into a regular matrix? As more and more CUIs are considered, this will lead to exceeding the memory limit of the m/c.

I have made changes in my forked repo to construct pmi directly using sparse matrix: https://github.com/kaushikacharya/cui2vec/commit/c33492d3eedf293c5348b10a68f7677490dbd6a4

If you want I can create a pull request.

bkompa commented 4 years ago

Hi there,

Thanks for your interest in the project -- your fork looks great. We'd welcome a PR.

kaushikacharya commented 4 years ago

@bkompa Pull Request created: https://github.com/beamandrew/cui2vec/pull/2