beamer-bridge / beamer

Beamer - Bridging rollups with L1 inherited security
https://beamerbridge.com
MIT License
45 stars 21 forks source link

beamer: agent: take the fill mutex before doing anything else when fi… #2111

Closed istankovic closed 1 year ago

istankovic commented 1 year ago

…lling

Otherwise it can happen that we do the timing checks before we obtain the mutex, and we are forced to wait on the mutex long enough that the timing check performed previously becomes invalid. Same reasoning applies to other checks, e.g. the min_source_balance, token allowance check etc.

compojoom commented 1 year ago

Looks good to me, but why is the test failing?

istankovic commented 1 year ago

Looks good to me, but why is the test failing?

Because it's broken. I have removed it now.