Include stack in error proplist

beamjs / erlv8

Erlang interface for V8

BSD 2-Clause "Simplified" License

126 stars 22 forks source link

Include stack in error proplist #77

Closed gleber closed 11 years ago

gleber commented 11 years ago

It does few other minor changes like adding ?is_v8 macro, adding Array:unpush/1 and Object:copy_properties_to/1

yrashk commented 11 years ago

does copy_properties_to really belong there?

gleber commented 11 years ago

It doesn't have to be there, but it is very useful :) I've replaced at least three instances of lists:foreach over Object:proplist doing Copy:set_value in beamjs with this one.

yrashk commented 11 years ago

Can we move it to some "utility module"?

gleber commented 11 years ago

In utility module it would not be as useful, but I get that copy_properties_to in object doesn't fit the way it works in JS. I'll move it

gleber commented 11 years ago

Moved them to erlv8_utils

yrashk commented 11 years ago

Thanks!