search

beamylabs / beamylabs-start

5 stars 5 forks source link

Pick up and make use of envs uploaded from webclient #43

Closed quite closed 3 years ago

AleksandarFilipov commented 3 years ago

@quite, is it fine to just merge this, as a first step, before web-client and other parts are updated?

quite commented 3 years ago

@AleksandarFilipov ah, yes!

AleksandarFilipov commented 3 years ago

@quite Vad händer om man lägger in fel tag. Lets have a call on this before we merge.

quite commented 3 years ago

@AleksandarFilipov i addressed that in the last commit. so if it cannot fetch any of the images due to bad tag, that should just be a NOP. no feedback to user though, that would be a bigger business. yes, i'm at the office today and available!

AleksandarFilipov commented 3 years ago

@quite I would love to merge this, but still need to understand how it works (yep, one would assume i knew, but I'm not fully up to speed here). Just ping me when you have time so that we can get this merged.

Consideration, If the uploaded file contains the same thing as the .env file - in that case, would it be possible for users with manual installations to use the upgrade file as the env file? I understand that this isn't the case, but could there be a next step allowing this.

So at distribribution time ("vanilla" system) we don't have any env file. Once we have clicked update (with or without custom tags) - from that point on we use the a env file. Is it file that the env file isn't ever removed. Will it just be replaced at next update/upgrade?

AleksandarFilipov commented 3 years ago

@quite I see that this works, part from the following, To make this operational it's not enough to git checkout upgradeenv (to simulate a upgrade from an existing installation) the following is also require

sudo systemctl stop beamylabs-upgrade.service
sudo systemctl start beamylabs-upgrade.service

This needs to "happen" automatically once upgrade is executed..... Not sure how/if we can fix this...

quite commented 3 years ago

@AleksandarFilipov yes, I came across that already, see: https://github.com/beamylabs/signalbroker-web-client/issues/29

About the use cases/flow I don't quite follow (I probably had something much simpler in mind). We need to talk it through properly. Might have time on monday, will ping..

AleksandarFilipov commented 3 years ago

@quite Think i have answers to all questions i need for now, with the exception of beamylabs/signalbroker-web-client#29

So you are suggesting that a reboot would do it? For some reason 'restart' isn't a valid option on my pi (i had to stop start). It's little unclear to me what's cached from the service point of view. The demon calls upgrade.sh would it help if we add code there?

quite commented 3 years ago

I'll rebase this to target branch hostagnostic.

quite commented 3 years ago

Rebased, revised and tested again.