search

beanbaginc / pillowfight

Eases the transition from PIL to Pillow for Python packages.
MIT License
20 stars 0 forks source link

Merge with Pillow? #1

Open aclark4life opened 10 years ago

aclark4life commented 10 years ago

This is great! Although it looks like pillowfight could potentially be included in Pillow, what do you think? I think we have a ticket for "doing the right thing" somewhere…

chipx86 commented 10 years ago

I am happy with any solution that solves the problem and takes it off our hands :) Especially if it benefits others.

What would the plan be for integration? The trick we hit was that, since we need to build eggs (our build process is tricky enough where source installs are not feasible for most of our users), and the requires.txt gets populated at egg build time, we didn't have a good way of doing this logic within the package needing PIL/Pillow. Hence the external source-based dependency, which could actually execute logic at install time.

aclark4life commented 10 years ago

Ah, I see. Well if you don't think it work then I probably agree with you. I was picturing a drop-in of pillowfight code into Pillow's setup.py… but you are saying that won't work for some reason?

chipx86 commented 10 years ago

Yeah, that was our initial plan, and we were going with that right up until we built a new release of our software last night and were in the pre-announcement sanity-checking phase.

When we ran bdist_egg, setup.py ran and picked a dependency, and listed that dependency in requires.txt. When we went to install it into a virtualenv, easy_install just went with that, as it doesn't execute setup.py unless it's a source package. So, instead of doing the right thing for the user's system, it was effectively hard-coding a dependency for them, which just brought us back to the original problem.

pillowfight was our last-minute solution to our "oh crap, now what" pre-release panic.

aclark4life commented 7 years ago

I would say this could also potentially go in the python-pillow organization (i.e. instead of in Pillow itself) if you ever get tired of hosting it. Or rather, if you feel it's generally useful and want to align closer with the Pillow project and the @python-pillow/pillow-team agrees, we could consider it.