search

beancount / beancount-mode

Emacs major-mode to work with Beancount ledger files
GNU General Public License v3.0
114 stars 32 forks source link

Flymake integration #37

Closed akirak closed 1 year ago

akirak commented 1 year ago

I have implemented a basic flymake support: flymake-bean-check.

If you wish, I will contribute the file to this repository or transfer the repository to your organization.

What option would you prefer?

blais commented 1 year ago

Fun! Thank you Komamura-san. Do you think adding the new file to the root of the beancount-mode would be sufficient? I'm okay with that; if you prefer to transfer repo I'm okay with that too (though given the size it's probably more sensible to add to beancount-mode if you prefer that).

On Mon, May 22, 2023 at 1:15 AM Akira Komamura @.***> wrote:

I have implemented a basic flymake support: flymake-bean-check https://github.com/akirak/flymake-bean-check.

If you wish, I will contribute the file to this repository or transfer the repository to your organization.

What option would you prefer?

— Reply to this email directly, view it on GitHub https://github.com/beancount/beancount-mode/issues/37, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACSBEZ6DAWWBJSJOGXIN6TXHLY6DANCNFSM6AAAAAAYJ43NHA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

akirak commented 1 year ago

adding the new file to the root of the beancount-mode

I think it's fine. The flymake backend doesn't depend on any third-party library, but the user requires Emacs 27.1 to use flymake. Iif beancount-mode assumes Emacs 27.1, the added library can be part of the package. Otherwise, you can ship it as a separate package.

I have created a PR #38. If you are fine with this, please feel free to merge it.