beancount / beancount-mode

Emacs major-mode to work with Beancount ledger files
GNU General Public License v3.0
113 stars 32 forks source link

Fold the flymake code into `beancount.el` #48

Open dnicolodi opened 5 months ago

dnicolodi commented 5 months ago

It does not make much sense for it to live in a separate source file.

dnicolodi commented 5 months ago

We should also add to flymake-diagnostic-functions from beancount-mode so people who want to use Flymake in Beancount can just enable flyamke-mode rather than having to call some ad-hoc function.

dnicolodi commented 5 months ago

The flymake code states a requirement for Emacs 27.1. Maybe it is time to drop support for Emacs 26...

blais commented 5 months ago

You know me I'm all in favor of dropping support for things too old, life's too short

On Mon, Jun 3, 2024, 10:58 Daniele Nicolodi @.***> wrote:

The flymake code states a requirement for Emacs 27.1. Maybe it is time to drop support for Emacs 26...

— Reply to this email directly, view it on GitHub https://github.com/beancount/beancount-mode/issues/48#issuecomment-2145421188, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACSBE7BWXWLZVOGEINPUGLZFSABFAVCNFSM6AAAAABIAITGM2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBVGQZDCMJYHA . You are receiving this because you are subscribed to this thread.Message ID: @.***>