search

beancount / beangulp

Importers framework for Beancount
GNU General Public License v2.0
54 stars 22 forks source link

Ignore entries without amount in amount_map #99

Open henrikssn opened 2 years ago

henrikssn commented 2 years ago

Fixes #98

dnicolodi commented 2 years ago

This avoids the exception that is otherwise raised when a MISSING value is encountered, however, I suspect that with this change the similarity comparison would be unable to match transactions with posting with missing values. Adding a test case for this would be very helpful.

henrikssn commented 2 years ago

This avoids the exception that is otherwise raised when a MISSING value is encountered, however, I suspect that with this change the similarity comparison would be unable to match transactions with posting with missing values. Adding a test case for this would be very helpful.

Yeah, I think you are right... Would a better solution be to store an (account, key): None entry in the map?