search

beancount / beanquery

A customizable light-weight SQL query tool that works on tabular data, including Beancount.
GNU General Public License v2.0
17 stars 12 forks source link

Setup type checker #7

Open doriath opened 3 years ago

doriath commented 3 years ago

@dnicolodi - I was thinking about setting up the mypy type checker in github actions (after fixing existing errors). Is that ok, or would you prefer another type checker (e.g. pytype)?

blais commented 3 years ago

Either one. I haven't used mypy, but I heard good things. In the beancount build I've been wanting to have pytype_* rules like at work, but last time I checked they were not available yet.

doriath commented 3 years ago

Let me try pytype, it will be good opportunity to try it out.

dnicolodi commented 3 years ago

I would prefer if we could use the same type checker for all the projects. I would stick to mypy unless there are compelling reasons.

blais commented 3 years ago

Can we have both?

On Sun, Apr 11, 2021 at 4:48 AM Daniele Nicolodi @.***> wrote:

I would prefer if we could use the same type checker for all the projects. I would stick to mypy unless there are compelling reasons.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/beancount/beanquery/issues/7#issuecomment-817272612, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACSBE7QWB6XEHTXUIDEGEDTIFO6RANCNFSM42W7HQFA .

doriath commented 3 years ago

I will setup both, so that we can analyze the pros and cons of both (and whether there is any cons of keeping both).