search

beancount / fava

Fava - web interface for Beancount
https://beancount.github.io/fava/
MIT License
1.97k stars 285 forks source link

When using Filter, Balance/Changes screen should not show accounts which have zero value because of the filter #1116

Closed prafullat closed 1 year ago

prafullat commented 4 years ago

See this URL for example: https://fava.pythonanywhere.com/huge-example-file/account/Expenses/balances/?filter=payee%3A%22Uncle+Boons%22

Uncle Boons filter is showing values for only Food and Restaurant, If we skip showing other accounts, it would be better.

yagebu commented 4 years ago

There's an option for that: show-accounts-with-zero-balance

prafullat commented 4 years ago

I used both of the following options, but it still showed empty accounts on balance/changes screen ( above URL)

1970-01-01 custom "fava-option" "show-accounts-with-zero-balance" "false"
1970-01-01 custom "fava-option" "show-accounts-with-zero-transactions" "false"
yagebu commented 4 years ago

You're quite right. These options are currently not respected in the balance and change account trees. A PR fixing that would be welcome.

prafullat commented 4 years ago

Ok, I would like to help with it. Can you please assign it to me?

prafullat commented 4 years ago

Hi, It looks like, it started working now. Not sure what has changed, but I do not see accounts which are zero or no transactions. Can you please confirm if any recent changes fix it?

prafullat commented 4 years ago

Added a fix in this PR : https://github.com/beancount/fava/pull/1118 Please take a look

xiaoyuesansui commented 1 year ago

I used both of the following options, but it still showed empty accounts on balance/changes screen ( above URL)

1970-01-01 custom "fava-option" "show-accounts-with-zero-balance" "false"
1970-01-01 custom "fava-option" "show-accounts-with-zero-transactions" "false"

hello mate, tried above lines on June 2023 ,Fava version 1.23.x it works well on my end

maybe someone fix the issues ?

yagebu commented 1 year ago

This will be fixed by #1664