search

beancount / smart_importer

Augment Beancount importers with machine learning functionality.
MIT License
246 stars 28 forks source link

refs #100 fixes tox lint #101

Closed johannesjh closed 3 years ago

johannesjh commented 3 years ago
johannesjh commented 3 years ago

@yagebu The sourcehut build fails with error message "No module named 'setuptools'". That is rather strange, setuptools should be part of the python installation, right?

yagebu commented 3 years ago

The sourcehut build fails with error message "No module named 'setuptools'". That is rather strange, setuptools should be part of the python installation, right?

It is not part of the Python distribution, so we need to install it separately. See #102.

We do specify it in our pyproject.toml, so theoretically it should be pulled in automatically, but that doesn't seem to happen.

yagebu commented 3 years ago

@johannesjh: It actually needs both pip and setuptools. I've pushed the fixes to the Arch CI to master, so you can just rebase this branch

johannesjh commented 3 years ago

We really should freeze package versions. Pylint on arch linux now complains about issues that were ignored on ubuntu.

yagebu commented 3 years ago

We really should freeze package versions.

I'm not a fan of freezing package versions without an automatic process in place that updates them. I think bumping the minimum version would be preferable.

johannesjh commented 3 years ago

Can you reproduce the unsubscriptable-object warning? I never got this warning. I tried specifying pylint>=2.6.2 in tox.ini, I still do not get the warning.

It might have to do with python 3.9, see https://github.com/PyCQA/pylint/issues/3882

yagebu commented 3 years ago

It might have to do with python 3.9

Yes, I've seen this one before, this is not due to the pylint version but due to the Python version

johannesjh commented 3 years ago

I added a github ci build matrix that reproduces the issue. As a workaround, I will instruct pylint to ignore these warnings.

johannesjh commented 3 years ago

Thank you for your help. I think we are all green now.