removes suggestions refs #91

beancount / smart_importer

Augment Beancount importers with machine learning functionality.

MIT License

246 stars 28 forks source link

removes suggestions refs #91 #103

Closed johannesjh closed 3 years ago

johannesjh commented 3 years ago

This pull request removes the suggestion feature from smart_importer. @yagebu could you do the review? Anybody else? Thank you so much!

Since this change can break other people's importers (if they used the suggest=True parameters), I think we should increment a major version. e.g.,

first release a version 0.2 that does not include the changes
release a version 1.0 that includes these changes

johannesjh commented 3 years ago

Thank you for the review.

Regarding versions: Ok yes, you are right. I think tagging v0.2 on the master branch would still be a good idea, prior to merging this. I think I can do these remaining steps.

johannesjh commented 3 years ago

the matrix build tried to upload the same artifact four times to pypi. the first upload succeeded, the three other uploads failed. i'll fix that in a separate branch.