search

beancount / smart_importer

Augment Beancount importers with machine learning functionality.
MIT License
248 stars 29 forks source link

please provide the hook helpers as an own package #97

Closed evgeni closed 3 years ago

evgeni commented 4 years ago

Hey,

I'd like to use the apply_hooks helper (and the ImporterHook "interface") from smart_importer/hooks.py in my own code, but would prefer to avoid depending on smart_importer due to the heavy dependencies it has (numpy, scipy).

Would it be possible to extract those into an own package, or - even better - move them to beancount itself?

Thanks! Evgeni

evgeni commented 4 years ago

And of course I just found the closed https://github.com/beancount/beancount/issues/458 which is sort of what I need, let's see.

johannesjh commented 3 years ago

Hi Evgeni, thank you for your interest, and thank you for pointing out beancount's new filter_function aka hook parameter from https://github.com/beancount/beancount/commit/ba7b4699d136ab02859013331d98b3c5971c841f. I think this is the way to go.

-> I propose to close this issue.