search

beancount / smart_importer

Augment Beancount importers with machine learning functionality.
MIT License
248 stars 29 forks source link

Filter transactions to only those referencing open accounts #98

Closed aclindsa closed 3 years ago

aclindsa commented 3 years ago

This is a quick attempt at addressing https://github.com/beancount/smart_importer/issues/26 by only using transactions with all their postings to/from open accounts as training data.

aclindsa commented 3 years ago

(And, yes, I'll fix up the failing tests if the general idea here is acceptable)

tarioch commented 3 years ago

I think that makes sense, I was first thinking about why filtering training data, but actually by not training such accounts they should never get suggested.

aclindsa commented 3 years ago

@tarioch Okay, I believe I've now fixed up the tests. It looks like the actual tests are passing, but there appears to something going on with the build environment/dependencies that's making it fail.

tarioch commented 3 years ago

@yagebu I think you know that bulid environment better, can you help?

aclindsa commented 3 years ago

@tarioch @yagebu After looking, I think the initial error was due to beancount moving to github from bitbucket. I'm working on trying to fix that up now, as well as a few other linter errors uncovered after the linter started working again!

aclindsa commented 3 years ago

Okay, I believe I've now updated the beancount URL to point to github and appeased the linter.