search

beandog / bluray_info

Linux/BSD Blu-ray utilities - bluray_info, bluray_copy, bluray_player
GNU General Public License v2.0
40 stars 2 forks source link

Select all titles #11

Closed rapperskull closed 9 months ago

rapperskull commented 3 years ago

This should fix #10

beandog commented 2 years ago

@rapperskull I've been debating in my head what to do on this one. I could select all of them by default, or I could add a flag to include the duplicate ones as well.

The problem is that libmpv uses TITLES_RELEVANT to get the list on a bluray. That means if someone displays all the titles / playlists on bluray_info, they're not going to necessarily match what can be done on bluray_player. The other apps would be affected because the title numbers are going to be different as well.

It looks like when running bd_select_playlist on one that is a duplicate and TITLES_RELEVANT is used in libbluray, it selects a different playlist than the one requested.

Where I'm at right now is the idea of adding the option of adding a flag to bluray_info to display duplicate titles.

rapperskull commented 2 years ago

I think the best option is to keep TITLES_RELEVANT as the default behavior, with a flag to use TITLES_ALL. This way compatibility is preserved, while still having the ability to show all titles.

beandog commented 9 months ago

Okay so this bug finally bit me, I found out that what libbluray decides are duplicates can change based on filesystem. I hit this initially with bd_list_titles which is using relevant as well.

This also fixes the confusion that if you look at the filesystem and there's a playlist that doesn't show up in bluray_info, running it on that missing playlist will actually switch to a completely different one.

@rapperskull thanks for bugging me about this one, you were right. :)