beandog / bluray_info

Linux/BSD Blu-ray utilities - bluray_info, bluray_copy, bluray_player
GNU General Public License v2.0
40 stars 2 forks source link

[Bug] [bluray_info] Json produced by filtered output is incorrect #13

Closed zscholl closed 1 year ago

zscholl commented 1 year ago

Thank you!

First off, thank you for these amazing tools! I was using makemkv and found it to be entirely confusing and not intuitive from the command line.

I wanted to report a minor issue with json output that only seems to happen if you filter the titles. Here are the details:

Example

$ bluray_info -j > all_titles.json
$ jq . all_titles.json
... all valid json ...
$ bluray_info -M 20 -j > long_titles.json
$ jq . long_titles.json
parse error: Expected another array element at line 1504, column 2

Notes

It seems like it's adding an extra , at the end of the last title entry when it shouldn't.

vim syntax highlighting:

Screenshot 2023-01-05 at 10 12 43 AM

I've attached the two json files I generated using those commands here. They're from disc one of Cowboy Bebop. Github won't let me attach .json extensions 🙄 all_titles.txt long_titles.txt

beandog commented 1 year ago

Thanks for the report @zscholl! It's fixed in tree, will go out in next release.

beandog commented 1 year ago

Ok 1.10 is out, let me know if you have any more problems, thanks!