search

beandog / dvd_info

Linux/BSD/Cygwin DVD utilities - dvd_info, dvd_copy, dvd_backup, dvd_player, dvd_rip, dvd_drive_status
http://dvds.beandog.org
GNU General Public License v2.0
22 stars 4 forks source link

[fedora-x86_64] Compile error v1.7_beta1 #1

Closed AkiraNorthstar closed 4 years ago

AkiraNorthstar commented 4 years ago

HI!, When i try to compile dvd_info (commit) under fedora 31, i always get errors and the build will stop. Can you have a look there and give me a direction on how to fix it? dvd_info-compile-error.txt Thanks a lot! Regrads, Christian

beandog commented 4 years ago

Christian,

I haven't tested before on Fedora 31, I've got a VM setup now. Current tree should build okay, send me another output if it dies.

beandog commented 4 years ago

Okay so I used the CFLAGS you had in your export (don't know why they're getting set anyway), minus the redhat spec ones and here's what I got:

CFLAGS='-O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection' ./configure

I cleaned up dvd_copy.c as well to be a bit safe for its string length on the filename, so it won't have any warnings there.

There are format-overflow warnings on dvd_backup, although they'll never trigger because the filename length of the DVD titles and its files will never exceed the variable size allotted. As long as you're not having your compiler exit on that warning, you should be good.

beandog commented 4 years ago

Okay, looked at it again, the actual error was dvd_backup wasn't building. It wasn't in the tree for a bit, but it's been fixed now anyway. You'll be good.