Note off command types and their unpacking conditions are inaccurate

beanieaxolotl / shinen-gax-python

Reimplementation of the GAX Sound Engine in Python

MIT License

2 stars 0 forks source link

Note off command types and their unpacking conditions are inaccurate #2

Closed beanieaxolotl closed 2 months ago

beanieaxolotl commented 2 months ago

I first assumed that 0x80 is an empty step, and 0x81 to be a note off command. This worked most of the time, but when a note off is paired with a effect command, this gets interpreted as a note with a semitone of 1 instead. I have noticed this in a few tracks, one being the main menu BGM from Drake & Josh: