search

beanit / asn1bean

ASN1bean (formerly known as jASN1) is a Java ASN.1 BER and DER encoding/decoding library
https://www.beanit.com/asn1/
Apache License 2.0
110 stars 45 forks source link

BerSerializable interface added to generated classes #14

Closed maddenj-ie closed 5 years ago

maddenj-ie commented 6 years ago

Addresses #13. Feedback welcome.

maddenj-ie commented 6 years ago

I didn't need to add any implementation of the interface because the generated classes already implement the required methods. So for example, in SequeneOfAll.java, from the test-gen directory of the compiler project, the encode and decode methods are already present. This change just adds an interface for those methods. I did not add the interface to any of the existing classes in org.openmuc.jasn1.ber as it would not be appropriate for all of them. There is no reason why It couldn't be added to some if desired.

maddenj-ie commented 5 years ago

Hi. Has anyone had a chance to review this?

sfeuerhahn commented 5 years ago

sorry, I cannot accept the pull request since its purpose is too special for your specific case.