beanlab / quest_framework

A Python framework for fault-tolerant workflows
0 stars 0 forks source link

Reorganize historian.py file #21

Closed ABCambridge closed 7 months ago

ABCambridge commented 7 months ago

... @kjstanding it might be good for you to describe your work here

kjstanding commented 7 months ago

I moved the History class to history.py and referenced it with an import statement

kjstanding commented 7 months ago

I moved all the EventRecord typed dictionaries to types.py and reference them with an import all statement

kjstanding commented 7 months ago

I optimized the imports in historian.py for History and the types. I also changed the imports in all the other src files that imported History or any event record types to be a direct import instead of indirect through historian.py.

kjstanding commented 7 months ago

Might be good to look at a few functions that reside outside of the Historian class that could maybe be moved to a separate file called utils.py

kjstanding commented 7 months ago

Created PR. Under review