beanshell / beanshell

Beanshell scripting language
Apache License 2.0
815 stars 183 forks source link

Fix illegal name for anonymous class in block #705

Closed nickl- closed 1 year ago

nickl- commented 1 year ago

Fixes #334 anonymous classes use the block name space for a named prefix which has / in the name, fix replaces / with _

Additional inner class tests Added tests for constructing non static JAVA compiled inner classes Added tests for extending static and non-statice JAVA compiled inner classes

codecov[bot] commented 1 year ago

Codecov Report

Merging #705 (158a9ae) into master (4def2cf) will increase coverage by 0.32%. The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #705      +/-   ##
============================================
+ Coverage     72.98%   73.30%   +0.32%     
- Complexity     2943     2951       +8     
============================================
  Files           108      108              
  Lines          9279     9293      +14     
  Branches       1824     1824              
============================================
+ Hits           6772     6812      +40     
+ Misses         2140     2118      -22     
+ Partials        367      363       -4     
Flag Coverage Δ
unittests 73.30% <100.00%> (+0.32%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/main/java/bsh/BSHAllocationExpression.java 85.08% <100.00%> (+7.01%) :arrow_up:
src/main/java/bsh/ClassGenerator.java 90.90% <100.00%> (+5.07%) :arrow_up:
src/main/java/bsh/This.java 80.45% <100.00%> (+0.12%) :arrow_up:
src/main/java/bsh/Types.java 76.35% <100.00%> (ø)
src/main/java/bsh/ClassGeneratorUtil.java 89.59% <0.00%> (+0.42%) :arrow_up:
src/main/java/bsh/Reflect.java 90.48% <0.00%> (+0.77%) :arrow_up:
src/main/java/bsh/BSHPrimarySuffix.java 84.41% <0.00%> (+1.29%) :arrow_up:
src/main/java/bsh/Invocable.java 83.03% <0.00%> (+1.33%) :arrow_up:
src/main/java/bsh/BlockNameSpace.java 94.44% <0.00%> (+5.55%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more