beanshell / beanshell

Beanshell scripting language
Apache License 2.0
815 stars 183 forks source link

Expect hash code collisions in reference cache #717

Closed nickl- closed 1 year ago

nickl- commented 1 year ago

Fixes #680 by adding the sum of char to int of the to string of a key we may mitigate pure hash code collisions.

codecov[bot] commented 1 year ago

Codecov Report

Merging #717 (f081612) into master (f301945) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master     #717   +/-   ##
=========================================
  Coverage     73.51%   73.51%           
  Complexity     2980     2980           
=========================================
  Files           108      108           
  Lines          9319     9319           
  Branches       1835     1835           
=========================================
  Hits           6851     6851           
  Misses         2114     2114           
  Partials        354      354           
Flag Coverage Δ
unittests 73.51% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/main/java/bsh/util/ReferenceCache.java 86.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more