beanshell / beanshell

Beanshell scripting language
Apache License 2.0
815 stars 183 forks source link

Reload typed variables #718

Closed nickl- closed 1 year ago

nickl- commented 1 year ago

Fixes #709 local variables listens to class loader changed events Improvement to the #707 and #708 fixes made before by reloading type from namespace instead of reevaluating the declared method nodes.

codecov[bot] commented 1 year ago

Codecov Report

Merging #718 (6263c6c) into master (f081612) will increase coverage by 0.04%. The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #718      +/-   ##
============================================
+ Coverage     73.51%   73.56%   +0.04%     
- Complexity     2980     2991      +11     
============================================
  Files           108      108              
  Lines          9319     9329      +10     
  Branches       1835     1841       +6     
============================================
+ Hits           6851     6863      +12     
+ Misses         2114     2112       -2     
  Partials        354      354              
Flag Coverage Δ
unittests 73.56% <100.00%> (+0.04%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/main/java/bsh/BSHFormalParameters.java 95.34% <100.00%> (+0.61%) :arrow_up:
src/main/java/bsh/BSHMethodDeclaration.java 100.00% <100.00%> (+3.17%) :arrow_up:
src/main/java/bsh/BSHPrimitiveType.java 100.00% <100.00%> (ø)
src/main/java/bsh/BSHTypedVariableDeclaration.java 100.00% <100.00%> (ø)
src/main/java/bsh/BshMethod.java 76.73% <100.00%> (+0.35%) :arrow_up:
src/main/java/bsh/Variable.java 80.32% <100.00%> (+1.38%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

sonatype-lift[bot] commented 1 year ago

🛠 Lift Auto-fix

Some of the Lift findings in this PR can be automatically fixed. You can download and apply these changes in your local project directory of your branch to review the suggestions before committing.[^1]

# Download the patch
curl https://lift.sonatype.com/api/patch/github.com/beanshell/beanshell/718.diff -o lift-autofixes.diff

# Apply the patch with git
git apply lift-autofixes.diff

# Review the changes
git diff

Want it all in a single command? Open a terminal in your project's directory and copy and paste the following command:

curl https://lift.sonatype.com/api/patch/github.com/beanshell/beanshell/718.diff | git apply

Once you're satisfied commit and push your changes in your project. [^1]: You can preview the patch by opening the patch URL in the browser.