Closed nickl- closed 1 year ago
Some of the Lift findings in this PR can be automatically fixed. You can download and apply these changes in your local project directory of your branch to review the suggestions before committing.[^1]
# Download the patch
curl https://lift.sonatype.com/api/patch/github.com/beanshell/beanshell/721.diff -o lift-autofixes.diff
# Apply the patch with git
git apply lift-autofixes.diff
# Review the changes
git diff
Want it all in a single command? Open a terminal in your project's directory and copy and paste the following command:
curl https://lift.sonatype.com/api/patch/github.com/beanshell/beanshell/721.diff | git apply
Once you're satisfied, commit and push your changes in your project. [^1]: You can preview the patch by opening the patch URL in the browser.
Merging #721 (31a2c34) into master (ccfb83b) will increase coverage by
0.60%
. The diff coverage is88.42%
.
@@ Coverage Diff @@
## master #721 +/- ##
============================================
+ Coverage 73.63% 74.24% +0.60%
- Complexity 2995 3041 +46
============================================
Files 108 108
Lines 9332 9354 +22
Branches 1842 1857 +15
============================================
+ Hits 6872 6945 +73
+ Misses 2109 2070 -39
+ Partials 351 339 -12
Flag | Coverage Δ | |
---|---|---|
unittests | 74.24% <88.42%> (+0.60%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
src/main/java/bsh/util/NameCompletionTable.java | 13.88% <14.28%> (ø) |
|
src/main/java/bsh/LHS.java | 74.35% <83.33%> (+4.73%) |
:arrow_up: |
src/main/java/bsh/Types.java | 80.99% <87.50%> (+4.63%) |
:arrow_up: |
src/main/java/bsh/Primitive.java | 94.33% <88.88%> (-1.55%) |
:arrow_down: |
src/main/java/bsh/BSHBinaryExpression.java | 90.62% <100.00%> (-1.33%) |
:arrow_down: |
src/main/java/bsh/BSHIfStatement.java | 100.00% <100.00%> (ø) |
|
src/main/java/bsh/BSHVariableDeclarator.java | 100.00% <100.00%> (ø) |
|
src/main/java/bsh/Interpreter.java | 85.20% <100.00%> (+5.12%) |
:arrow_up: |
src/main/java/bsh/Invocable.java | 83.03% <100.00%> (ø) |
|
src/main/java/bsh/Operators.java | 94.66% <100.00%> (-0.43%) |
:arrow_down: |
... and 8 more |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Increase cast scope, makes types more compatible and less reason to complain. Fixed box types should init as null and not with default values. Fixed return values from typed variables and fields after assignment, not the assigned value. Added string repeat through * STAR operator, as per lists and arrays repeat. Fixed unable to assign null through invocable field. Reduced cast complexity which in turn improves method matching.