beanshell / beanshell

Beanshell scripting language
Apache License 2.0
815 stars 183 forks source link

Add the missing console input stream delegate #742

Closed opeongo closed 1 month ago

opeongo commented 11 months ago

The console delegate methods in Interpreter were missing a method to change the input stream. This PR adds the missing method.

codecov[bot] commented 11 months ago

Codecov Report

Attention: 656 lines in your changes are missing coverage. Please review.

Comparison is base (b1998b1) 74.24% compared to head (455980d) 74.24%. Report is 1026 commits behind head on master.

Files Patch % Lines
src/main/java/bsh/Interpreter.java 85.03% 51 Missing and 21 partials :warning:
src/main/java/bsh/BshClassManager.java 65.73% 48 Missing and 13 partials :warning:
src/main/java/bsh/NameSpace.java 87.87% 40 Missing and 17 partials :warning:
src/main/java/bsh/ClassGeneratorUtil.java 89.59% 35 Missing and 14 partials :warning:
src/main/java/bsh/BshMethod.java 76.73% 26 Missing and 21 partials :warning:
src/main/java/bsh/Name.java 86.76% 20 Missing and 23 partials :warning:
src/main/java/bsh/LHS.java 74.35% 28 Missing and 12 partials :warning:
src/main/java/bsh/Invocable.java 83.03% 23 Missing and 15 partials :warning:
src/main/java/bsh/DelayedEvalBshMethod.java 61.97% 26 Missing and 1 partial :warning:
src/main/java/bsh/BSHPrimarySuffix.java 84.41% 17 Missing and 7 partials :warning:
... and 30 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #742 +/- ## ========================================= Coverage 74.24% 74.24% - Complexity 3041 3043 +2 ========================================= Files 108 108 Lines 9354 9358 +4 Branches 1857 1857 ========================================= + Hits 6945 6948 +3 Misses 2070 2070 - Partials 339 340 +1 ``` | [Flag](https://app.codecov.io/gh/beanshell/beanshell/pull/742/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=beanshell) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/beanshell/beanshell/pull/742/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=beanshell) | `74.24% <87.44%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=beanshell#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

opeongo commented 4 months ago

This PR seems to have been mangled by the forced-push that was done last month. Does it need to deleted and pushed again?

nickl- commented 4 months ago

This PR seems to have been mangled by the forced-push that was done last month. Does it need to deleted and pushed again?

Something is funny with the code coverage too, would you mind terribly to redo the PR please?

nickl- commented 1 month ago

Not sure why the build failed for Java 11. Looks straight forward enough.

Lets see what happens when we merge.

nickl- commented 1 month ago

Build succeeded \o/