search

beanumber / openWAR

An R package enabling the computation of openWAR using MLBAM data
99 stars 33 forks source link

bis_boxscore.xml not available for 2019 games #118

Open james-ingold opened 5 years ago

james-ingold commented 5 years ago

bis_boxscore.xml is not available for games this season. For example, this directory has no bis_boxscore.xml which is a file this library depends on to build out war: http://gd2.mlb.com/components/game/mlb/year_2019/month_03/day_29/gid_2019_03_29_anamlb_oakmlb_1/

I'm looking at working around this, but wondering if anyone has some info on why gameday at mlb.com isn't providing this file anymore?

beanumber commented 5 years ago

It looks like the file is now just called boxscore.xml.

james-ingold commented 5 years ago

@beanumber have you been able to use openWar for the 2019 season/is this library still maintained? I haven't been able to get the boxscore.html file to work but I haven't been able to spend enough time looking at it.

beanumber commented 5 years ago

I haven't been able to spend any time on it either @james-ingold. I'm guessing that it is a simple fix but it will require some digging to verify backwards compatibility.

james-ingold commented 5 years ago

Hey @beanumber I'm trying to look into this, pulled down latest and getting Error during wrapup: Evaluation error: object 'isBIP' not found in the makeWAR.GameDayPlays_Runs function: bip.idx <- which(x$data$isBIP == TRUE & !is.na(x$data$our.x))

Do you know how to resolve this issue?

gjm112 commented 5 years ago

I keep running into this problem too. If I recall correctly, it was an issue with dplyr? But I'm only like 25% sure that was it.

On Wed, Jul 17, 2019 at 9:03 AM James Ingold notifications@github.com wrote:

Hey @beanumber https://github.com/beanumber I'm trying to look into this, pulled down latest and getting Error during wrapup: Evaluation error: object 'isBIP' not found in the makeWAR.GameDayPlays_Runs function: bip.idx <- which(x$data$isBIP == TRUE & !is.na(x$data$our.x))

Do you know how to resolve this issue?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/beanumber/openWAR/issues/118?email_source=notifications&email_token=AAIZJJJ745QPUPVPJEDAUUTP74RCLA5CNFSM4HEL7MUKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2EJQZI#issuecomment-512268389, or mute the thread https://github.com/notifications/unsubscribe-auth/AAIZJJPDGU56NGM2B3OEXTLP74RCLANCNFSM4HEL7MUA .

-- Gregory J. Matthews, Ph.D. Data Science Program Director Assistant Professor Department of Mathematics and Statistics Loyola University Chicago E-mail: gjm112 -at- gmail.com Blog: StatsInTheWild.com Art: etsy.me/1JAsYz9 Twitter: @StatsInTheWild http://www.twitter.com/StatsInTheWild Twitter: @StatsClass http://www.twitter.com/statsclass