search

beanumber / teamcolors

an R package providing color palettes for pro sports teams
47 stars 12 forks source link

Added NWSL colors, added function to create palettes according to sport #17

Closed adror1 closed 4 years ago

adror1 commented 4 years ago

I've added the colors for the National Women's Soccer League (NWSL) to the package. I've also created a function show_sport_col, which allows users to see all the palettes for the leagues of a particular sport.

gjm112 commented 4 years ago

Yes! Thank you!

On Mon, Nov 18, 2019 at 2:55 PM Arielle Dror notifications@github.com wrote:

I've added the colors for the National Women's Soccer League (nwsl) to the package. I've also created a function show_sport_col, which allows users to see all the palettes for the leagues of a particular sport.

You can view, comment on, or merge this pull request online at:

https://github.com/beanumber/teamcolors/pull/17 Commit Summary

  • first attempt to add NWSL data
  • fixed scraper (there was a missing pipe), fixed nwsl script to actually add properly to the teamcolors df, added function that shows palettes by sport, properly compiled rda file.

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/beanumber/teamcolors/pull/17?email_source=notifications&email_token=AAIZJJKUTPGGDBDJ4MFDLKLQUL6MLA5CNFSM4JO2AC32YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H2E7IZQ, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIZJJJYVHO65HNF6PUTRE3QUL6MLANCNFSM4JO2AC3Q .

-- Gregory J. Matthews, Ph.D. Data Science Program Director Assistant Professor Department of Mathematics and Statistics Loyola University Chicago E-mail: gjm112 -at- gmail.com Blog: StatsInTheWild.com Art: StatsInTheWild.com/art Twitter: @StatsInTheWild http://www.twitter.com/StatsInTheWild Twitter: @StatsClass http://www.twitter.com/statsclass

adror1 commented 4 years ago

Unsure of why Travis CI is failing. I wonder if it's because it doesn't have Clara's updates, but those aren't merged so that would not be it.

beanumber commented 4 years ago

Travis:

* checking for missing documentation entries ... WARNING

Undocumented code objects:

  ‘show_sport_col’

I think you forgot to commit and push the man/show_sport_col.Rd file. It is generated automatically and then passes the check on my end, so I will merge this and clean it up.