search

beanumber / teamcolors

an R package providing color palettes for pro sports teams
47 stars 12 forks source link

Change Oakland Raiders to Las Vegas Raiders in teamcolors dataframe #22

Closed benjaminrobinson closed 1 year ago

benjaminrobinson commented 4 years ago

Just thought I'd put this request in since the base teamcolors dataset will need to change to accurately reflect the Raiders move from Oakland to Las Vegas. Thanks for this package guys!

beanumber commented 4 years ago

Thanks I will fix it as soon as I get a chance

benjaminrobinson commented 4 years ago

Thanks, @beanumber! I wrote some code to get around this for the time being but would be great if I didn't have to!

JTGamber89 commented 3 years ago

In the same vein, the Washington Redskins ought to be renamed to be the Washington Football Team, pending their re-brand in 2022. Thanks for the great package!

benjaminrobinson commented 3 years ago

The other thing here is that the teams in the English Premier League change each year, making the EPL section of this package moot as not all current EPL teams are included.

gjm112 commented 3 years ago

I'll do this Monday.

What epl teams are missing?

On Sun, Jul 25, 2021, 3:45 PM Ben Robinson @.***> wrote:

The other thing here is that the teams in the English Premier League change each year, making the EPL section of this package moot as not all current EPL teams are included.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/beanumber/teamcolors/issues/22#issuecomment-886255465, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIZJJLQ2WOTYOQYHSJWVZDTZRZVNANCNFSM4LWHFQ5Q .

benjaminrobinson commented 3 years ago

For this year, you're missing:

- Norwich City
- Leeds United
- Brentford FC
- Aston Villa
- Wolverhampton Wanderers

Might be worthwhile adding all EPL clubs ever? premierleague.com/clubs

I did a diff and these are the 30 others teams you're missing from all teams who've ever participated in EPL football:

- Aston Villa
- Barnsley
- Birmingham City
- Blackburn Rovers
- Blackpool
- Bolton Wanderers
- Bradford City
- Brentford
- Cardiff City
- Charlton Athletic
- Coventry City
- Derby County
- Fulham
- Hull City
- Ipswich Town
- Leeds United
- Middlesbrough
- Norwich City
- Nottingham Forest
- Oldham Athletic
- Portsmouth
- Queens Park Rangers
- Reading
- Sheffield United
- Sheffield Wednesday
- Sunderland
- Swindon Town
- Wigan Athletic
- Wimbledon
- Wolverhampton Wanderers
gjm112 commented 3 years ago

I suppose we should just add all the teams that have ever played EPL.

On Sun, Jul 25, 2021, 4:26 PM Ben Robinson @.***> wrote:

For this year, you're missing:

  • Norwich City
  • Leeds United
  • Brentford FC
  • Aston Villa
  • Wolverhampton Wanderers

Might be worthwhile adding all EPL clubs ever? premierleague.com/clubs

I did a diff and these are the 30 others teams you're missing from all teams who've ever participated in EPL football:

  • Aston Villa
  • Barnsley
  • Birmingham City
  • Blackburn Rovers
  • Blackpool
  • Bolton Wanderers
  • Bradford City
  • Brentford
  • Cardiff City
  • Charlton Athletic
  • Coventry City
  • Derby County
  • Fulham
  • Hull City
  • Ipswich Town
  • Leeds United
  • Middlesbrough
  • Norwich City
  • Nottingham Forest
  • Oldham Athletic
  • Portsmouth
  • Queens Park Rangers
  • Reading
  • Sheffield United
  • Sheffield Wednesday
  • Sunderland
  • Swindon Town
  • Wigan Athletic
  • Wimbledon
  • Wolverhampton Wanderers

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/beanumber/teamcolors/issues/22#issuecomment-886260030, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIZJJLME3ONVFNTVD5CXQDTZR6SDANCNFSM4LWHFQ5Q .

beanumber commented 3 years ago

See also #26