bear / parsedatetime

Parse human-readable date/time strings
Apache License 2.0
695 stars 106 forks source link

Test failure: eom is correct, but expectation is wrong #146

Closed rbu closed 8 years ago

rbu commented 8 years ago

This test fails in december, because the source time of calculation (s) is in the next year (because it is generated after yr += 1).

Review on Reviewable

codecov-io commented 8 years ago

Current coverage is 77.09%

Merging #146 into master will not affect coverage as of f816af1

@@            master    #146   diff @@
======================================
  Files           14      14       
  Stmts         1554    1554       
  Branches       294     294       
  Methods          0       0       
======================================
  Hit           1198    1198       
  Partial         93      93       
  Missed         263     263       

Review entire Coverage Diff as of f816af1

Powered by Codecov. Updated on successful CI builds.

bear commented 8 years ago

nice! thanks for taking the time to fix this!