search

bear / parsedatetime

Parse human-readable date/time strings
Apache License 2.0
695 stars 106 forks source link

unwrap dictionary comprehensions to allow for python 2.6 to work - Issue #156 #157

Closed bear closed 8 years ago

bear commented 8 years ago

as this is the only place where this type of code was found, I just unwrapped it so python 2.6 was still viable

Review on Reviewable

codecov-io commented 8 years ago

Current coverage is 77.07%

Merging #157 into master will increase coverage by +0.04% as of 3311ddd

@@            master    #157   diff @@
======================================
  Files           14      14       
  Stmts         1563    1566     +3
  Branches       297     296     -1
  Methods          0       0       
======================================
+ Hit           1204    1207     +3
  Partial         95      95       
  Missed         264     264

Review entire Coverage Diff as of 3311ddd

Powered by Codecov. Updated on successful CI builds.

bmw commented 8 years ago

Oh wow! Thanks for being so responsive the last couple days and looking at these issues. Doing both automated and manual tests with Python 2.6, I can't create the issue anymore using this patch.

bear commented 8 years ago

glad it's working for you - i'll merge this in now.