bear / parsedatetime

Parse human-readable date/time strings
Apache License 2.0
694 stars 105 forks source link

Added simple logging in nlp #194

Closed idpaterson closed 5 years ago

idpaterson commented 8 years ago

The logging identifies which expressions produce a leftmost match as nlp moves its way through the input string. It will not log every match, only the ones that are better than the previous match. This was necessary to resolve a few cases of nlp sending what seemed to be the wrong text to parse once I started tinkering with the period and quotes pre-processing step in nlp.

See #193


This change is Reviewable

codecov-io commented 8 years ago

Current coverage is 77.06% (diff: 69.23%)

Merging #194 into v3.0 will decrease coverage by 0.06%

@@               v3.0       #194   diff @@
==========================================
  Files            14         14          
  Lines          1570       1583    +13   
  Methods           0          0          
  Messages          0          0          
  Branches        288        288          
==========================================
+ Hits           1211       1220     +9   
- Misses          266        270     +4   
  Partials         93         93          

Powered by Codecov. Last update 39405f7...3431f12

bear commented 8 years ago

Reviewed 1 of 1 files at r1. Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable