search

bear / parsedatetime

Parse human-readable date/time strings
Apache License 2.0
695 stars 106 forks source link

Allow day start hour to be configurable - by default 9 as now #203

Closed nishantd closed 7 years ago

nishantd commented 8 years ago

When creating a Calendar, allow the day start hour to be passed in. By default, remains at 9 - the way it currently is.

This change is Reviewable

bear commented 7 years ago

Reviewed 6 of 6 files at r1. Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable

bear commented 7 years ago

merging - the lint errors appear to not be related to this code

bear commented 7 years ago

and I realized now that I wasn't even testing the v3 branch! doh!

i'll fix the lint errors in a bit - thanks for the code