bear / python-twitter

A Python wrapper around the Twitter API.
Apache License 2.0
3.41k stars 955 forks source link

timelines endpoint #237

Open k0a1a opened 9 years ago

k0a1a commented 9 years ago

are you plannoing to support https://api.twitter.com/1.1/timelines/timeline.json endpoint?

bear commented 9 years ago

which API call is that? I don't see any mention of /timelines in the current API docs - can you give me the API docs link?

k0a1a commented 9 years ago

my bad, 'timelines/timeline.json' is an obsolete name for https://api.twitter.com/1.1/collections/entries.json which is described here https://dev.twitter.com/rest/reference/get/collections/entries

ryankicks commented 9 years ago

I did a fork and added some of this here: https://github.com/ryankicks/python-twitter

If @k0a1a is interested in merging or helping me merge?

k0a1a commented 9 years ago

@ryankicks could you point me to collections relevant code in your fork?

ryankicks commented 9 years ago

Absolutely. My fork was just in preparation (a year ago) so the latest entries are collections related. I just updated the latest code to reflect the new endpoints and the use of Collections vs. Custom Timelines (the old terminology)

https://github.com/ryankicks/python-twitter/commits/master

bear commented 9 years ago

say the word and I'll add you to the collaborator's list so you both can work on this new code

ryankicks commented 9 years ago

I am not confident in my Python SKILLZ enough to be worthy to submit. O_O

bear commented 9 years ago

submit it via a PR and we can review it

k0a1a commented 9 years ago

@ryankicks thanks for pushing the updates, appreciated. I'm going to see if I can contribute. @bear neither too confident to add code right away but will keep you informed on my progress

ryankicks commented 9 years ago

I should also add that the Collections endpoints require additional privileges to access. Feel free to mail me (rchoi AT twitter.com) in advance the API tokens so I can whitelist them for your/any testing.

I'll also add this to the code itself so it's more clear how to use them. Sound good?

bear commented 9 years ago

thanks @ryankicks ! Please do file an issue against me for any code or doc updates you need.