search

bear / python-twitter

A Python wrapper around the Twitter API.
Apache License 2.0
3.41k stars 955 forks source link

Feature: Allow ability to upload gifs in the range of 5MB to 15MB. #663

Closed Bracciata closed 2 years ago

Bracciata commented 4 years ago

Fixes https://github.com/bear/python-twitter/issues/662.

This is my first commit to this repository and I do have a couple of questions.

  1. Would it be preferred that we add the media category for all gifs?
  2. Would it be better to pass the media category for all gifs?

Thank you for the help!

This change is Reviewable

Bracciata commented 4 years ago

Also, the information used to create this fix was found at https://developer.twitter.com/en/docs/media/upload-media/uploading-media/media-best-practices#gif-specs. Based off them stating use media category for large gifs I did not apply the logic to smaller gifs, however, I understand if that is what the core developers determine to be the best fit.