bearded-avenger / wp-live-search

A live search plugin for WordPress that utilizes REST API + Backbone + Underscore
http://nickhaskins.com/wp-live-search/
GNU General Public License v2.0
101 stars 13 forks source link

No way to pass literal false into shortcode parameters #11

Open kevinlangleyjr opened 9 years ago

kevinlangleyjr commented 9 years ago

Unfortunately, when you pass false as an parameter within a shortcode, it is not a literal false but is instead a string of "false". But here, https://github.com/bearded-avenger/wp-live-search/blob/master/public/includes/class.shortcode.php#L53 you are checking for a literal false which is just impossible since it is provided via a shortcode attribute.

I would love it if all of the logic here was actually separated out from the shortcode handler and the shortcode handler just called the template function instead of vice versa. The template function that is provided has very limited attributes that are able to be set in comparison.