search

beardedio / terraria

Docker images to run a Terraria Server. Images with TShock Server or Vanilla Server are available.
MIT License
116 stars 55 forks source link

tshock-dev-latest missing serverplugins #21

Closed fujin closed 4 years ago

fujin commented 4 years ago

Hey!

Thank you for putting this all together.

I spun up a tshock-4.4.0-pre11 server and found the problem with using ropes (https://github.com/Pryaxis/TShock/pull/2042)

Anyway, I figured I would be able to just fire up the tshock-dev-latest to get this fix? It looks like appveyor etc is plumbed up correctly. However, when started up, it looked like vanilla! The TShockAPI.dll is in the root of the zip rather than under ServerPlugins. I tried "fixing" that by creating the directory and moving it into it, but it seemed like it was much older version of tshock running - I'll admit to being pretty new to Terraria in general. :)

I'm not sure what's going on here but if you have a chance to spin up the tshock-dev-latest and let me know what you see vs. what you expect, perhaps I can take a stab at fixing?

cheers!

fujin commented 4 years ago

I just noticed the artifacts from GitHub Actions are more complete than those in AppVeyor. I'm going to try one of those. https://github.com/Pryaxis/TShock/actions/runs/134194171

fujin commented 4 years ago

Seems like branch:general-devel is:completed workflow:"Build Server" event:push might work as an Actions filter for those artifacts.