search

beardedspice / beardedspice

Mac Media Keys for the Masses
http://beardedspice.github.io
2.83k stars 279 forks source link

[App Support] music.youtube.com #805

Open marceltt opened 6 years ago

marceltt commented 6 years ago

Please add support for the YouTube Music website: https://music.youtube.com

Cheers!

gapurov commented 6 years ago

I will take care of it today and make a PR

ainth commented 6 years ago

I gave it a shot. Feel free to steal any part of https://gist.github.com/ainth/2ac4375a31672ba520e68d11084359a6. Some selectors could be better and some are not i18n friendly.

The main problem I ran into was compatibility with the youtube strategy which matches the tab against format: "%K LIKE[c] '*youtube.com/watch*'", Youtube music urls look like https://music.youtube.com/watch?v=NCtzkaL2t_Y&list=RDAMVMNCtzkaL2t_Y so the youtube strategy winds up being selected. I changed my local youtube strategy to match www.youtube.com but haven't thought through edge cases there. I suspect there's no way to get it working without changing the main youtube strategy.

gapurov commented 6 years ago

@ainth thank you for the hint and your work

gapurov commented 6 years ago

I have almost finished the PR, but unfortunately won't be able to complete it until the end of the next week.

Spandan-Madan commented 6 years ago

Great job everybody working on this. Eagerly looking forward to music.youtube.com support!

Srijancse-zz commented 6 years ago

Yes, looking forward to it. Thanks :)

aleohl commented 6 years ago

@gapurov Any news on your solution? 💯

gapurov commented 6 years ago

Sorry for the delay. I made a PR, but I don't know how long will it take for the maintainers to merge it. You can use it right now. Here is the gist with updated Youtube and new YoutubeMusic Media Strategies.

  1. Save both files from the gist as YouTube-Temp.bsstrategy and YouTubeMusic.bsstrategy
  2. Disable in BeardedSpice -> Preferences... -> Youtube
  3. Import Youtube-Temp.bsstrategy
  4. Import YoutubeMusic.bsstrategy

It should work. It is not working with the newest Chrome Version, but with Yandex Browser and other Chromium based there were no problems.

Update 29.07.2018: With the newest update of Chrome/Safari you have to View/Developer/Allow JavaScript from Apple Events to make BeardedSpice work, just as described in the issue 818

leonardaustin commented 6 years ago

@gapurov Works perfectly, thanks very much.

mmavko commented 5 years ago

Any news about official support of this?

zamf commented 5 years ago

Hi, sounds like the latest version does not have support for YT Music, I would prefer to have the PR merged than add the separate bsstrategy file. Thank you!

kendallroth commented 5 years ago

Any update on whether this will be merged or what is standing in the way?

Edit: Can confirm that the steps above still work

rudimusmaximus commented 4 years ago

This seems to be supported as long as you chrome > view > developer > allow javascript from apple events

as described in #818

Maybe add a link in preferences to a page with notes like these? Anyway, thanks for the great app.