Open marceltt opened 6 years ago
I will take care of it today and make a PR
I gave it a shot. Feel free to steal any part of https://gist.github.com/ainth/2ac4375a31672ba520e68d11084359a6. Some selectors could be better and some are not i18n friendly.
The main problem I ran into was compatibility with the youtube strategy which matches the tab against format: "%K LIKE[c] '*youtube.com/watch*'",
Youtube music urls look like https://music.youtube.com/watch?v=NCtzkaL2t_Y&list=RDAMVMNCtzkaL2t_Y
so the youtube strategy winds up being selected. I changed my local youtube strategy to match www.youtube.com
but haven't thought through edge cases there. I suspect there's no way to get it working without changing the main youtube strategy.
@ainth thank you for the hint and your work
I have almost finished the PR, but unfortunately won't be able to complete it until the end of the next week.
Great job everybody working on this. Eagerly looking forward to music.youtube.com support!
Yes, looking forward to it. Thanks :)
@gapurov Any news on your solution? 💯
Sorry for the delay. I made a PR, but I don't know how long will it take for the maintainers to merge it. You can use it right now. Here is the gist with updated Youtube and new YoutubeMusic Media Strategies.
It should work. It is not working with the newest Chrome Version, but with Yandex Browser and other Chromium based there were no problems.
Update 29.07.2018: With the newest update of Chrome/Safari you have to View/Developer/Allow JavaScript from Apple Events to make BeardedSpice work, just as described in the issue 818
@gapurov Works perfectly, thanks very much.
Any news about official support of this?
Hi, sounds like the latest version does not have support for YT Music, I would prefer to have the PR merged than add the separate bsstrategy file. Thank you!
Any update on whether this will be merged or what is standing in the way?
Edit: Can confirm that the steps above still work
This seems to be supported as long as you chrome > view > developer > allow javascript from apple events
as described in #818
Maybe add a link in preferences to a page with notes like these? Anyway, thanks for the great app.
Please add support for the YouTube Music website: https://music.youtube.com
Cheers!